DM-27185: ptc.py fails with ptcFitType=FULLCOVARIANCE #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
force-pushed
the
tickets/DM-27185
branch
from
7debc95
to
8758c92
Compare
czwa
approved these changes
Nov 6, 2020
python/lsst/cp/pipe/ptc.py
Outdated
| @@ -654,6 +666,8 @@ def measureMeanVarCov(self, exposure1, exposure2, region=None, covAstierRealSpac | |||
| wDiff = np.where(diffIm.getMask().getArray() == 0, 1, 0) | |||
| w = w12*wDiff | |||
|
|
|||
| w = wDiff | |||
There was a problem hiding this comment.
Do you need to calculate w1 and w2 now? If I'm reading this correctly, you now only check the difference image, and don't use w12, right?
| @@ -601,8 +602,6 @@ def fitFullModel(self, pInit=None, nSigma=5.0, maxFitIter=3): | |||
| if counter == maxFitIter: | |||
| break | |||
|
|
|||
| if ierr not in [1, 2, 3, 4]: | |||
There was a problem hiding this comment.
Are these errors not a problem anymore? Do they not cause raisable errors? Maybe just a comment that this triggers the "else" statement on ptc.py L536 if I'm following correctly (the errors yield a None that results in the bad amp detection and NaN entries as appropriate).
It might also be good to warn if it stops iterating from hitting the maxFitIter.
| @@ -282,6 +282,51 @@ def makeDataRefList(self, namespace): | |||
| self.refList += refList | |||
|
|
|||
|
|
|||
| def irlsFit(initialParams, dataX, dataY, function, weightsY=None): | |||
There was a problem hiding this comment.
The two commits adding this should be squashed together so the indentations are correct on the first ticket.
plazas
force-pushed
the
tickets/DM-27185
branch
2 times, most recently
from
5f3a373
to
0f1b4c8
Compare
Fix bug in indentation in utils
plazas
force-pushed
the
tickets/DM-27185
branch
from
0f1b4c8
to
537ed4d
Compare
Fix typo in docstring
plazas
force-pushed
the
tickets/DM-27185
branch
from
537ed4d
to
5a600b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.