DM-27437: Have maxMeanSignal (and minMeanSignal) be a list per amp, instead of a single number in the PTC task #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
requested changes
Nov 6, 2020
python/lsst/cp/pipe/ptc.py
Outdated
| @@ -101,14 +101,16 @@ class MeasurePhotonTransferCurveTaskConfig(pexConfig.Config): | |||
| default=1, | |||
| ) | |||
| minMeanSignal = pexConfig.Field( | |||
There was a problem hiding this comment.
Can this use pexConfig.DictField instead? This won't have a clean command line interface (I think you need to use a config file to set DictField entries), but it would put the type checking into the config object instead of forcing some later parsing. The lack of a command line interface will also be mitigated by the switch to gen3.
An example of the config field: https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/ingest.py#L58
An example of setting the values: https://github.com/lsst/obs_lsst/blob/master/config/ucd/ingestCalibs.py#L14
There was a problem hiding this comment.
Thanks, I'll try this.
czwa
approved these changes
Nov 7, 2020
plazas
force-pushed
the
tickets/DM-27437
branch
from
ce7f342
to
af74216
Compare
plazas
force-pushed
the
tickets/DM-27437
branch
from
af74216
to
8ef543d
Compare
Modify docstring
plazas
force-pushed
the
tickets/DM-27437
branch
from
8ef543d
to
2e5aafa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.