tickets/DM-15772 - Rename the task, its configClass, and all mentions of its name #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
reviewed
Nov 5, 2018
python/lsst/cp/pipe/runEotestTask.py
Outdated
| @@ -179,7 +179,7 @@ def validate(self): | |||
| getattr(self, task).output_dir = self.eotestOutputPath | |||
|
|
|||
|
|
|||
| class CpTask(pipeBase.CmdLineTask): | |||
| class RunEotestTask(pipeBase.CmdLineTask): | |||
| """ | |||
| Calibration (Products) Production (CP) task. | |||
There was a problem hiding this comment.
Should this topline description be updated too?
There was a problem hiding this comment.
Yes, yes it should.
There was a problem hiding this comment.
And, come to think of it, a little more of that docstring too actually...
mfisherlevine
force-pushed
the
tickets/DM-15772
branch
from
9cfc825
to
63da794
Compare
mfisherlevine
force-pushed
the
tickets/DM-15772
branch
2 times, most recently
from
2caf8c0
to
8865f6f
Compare
mfisherlevine
force-pushed
the
tickets/DM-15772
branch
from
8865f6f
to
83dd95c
Compare
mfisherlevine
force-pushed
the
tickets/DM-15772
branch
from
1b90e92
to
976477e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.