DM-28457: In cpCombine.py, the config option "combine" should be a string, not the integer stats value #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
reviewed
Jan 27, 2021
| doc="Statistic to use for combination (from lsst.afw.math)", | ||
| dtype=str, | ||
| default='MEANCLIP', | ||
| doc="Statistic name to use for combination (from lsst.afw.math)", |
There was a problem hiding this comment.
I guess the only option for the user to know the possible options is to look at Statistics.h, no?
There was a problem hiding this comment.
I think if this gets changed more than just to compare against eotest, then it probably should be made into a ChoiceField.
plazas
reviewed
Jan 27, 2021
| @@ -524,7 +524,7 @@ def fitPtc(self, dataset): | |||
| if dataset.ptcFitType: | |||
| ptcFitType = dataset.ptcFitType | |||
| else: | |||
| raise RuntimeError(f"ptcFitType is None of empty in PTC dataset.") | |||
| raise RuntimeError("ptcFitType is None of empty in PTC dataset.") | |||
There was a problem hiding this comment.
Thanks for fixing this type. Can you fix the other typo ("None or empty" instead of "None of empty") before you merge?
There was a problem hiding this comment.
I think this was resolved on another ticket. I fixed this on my branch to avoid a linter error, and it looks like someone else pushed first.
plazas
approved these changes
Jan 27, 2021
czwa
force-pushed
the
tickets/DM-28457
branch
from
0780bf2
to
46f262f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the CalibCombineTask statistics properties by name.