DM-29272: PTC task: Validate that the variance calculation provided by awf and the C_00 entry of the covariance matrix produced via FFT using Astier's code is the same #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
approved these changes
Apr 6, 2021
| # Compare Cov[0,0] and afwMath.VARIANCECLIP | ||
| # covDiffAstier[0] is the Cov[0,0] element, [3] is the variance, and there's a factor of 0.5 | ||
| # difference with afwMath.VARIANCECLIP. | ||
| thresholdPercentage = 1. # 1% |
There was a problem hiding this comment.
Would it make more sense to have this as a config field with a default value of 1.0 than have it hard coded here?
| @@ -112,7 +112,7 @@ class PhotonTransferCurveExtractConfig(pipeBase.PipelineTaskConfig, | |||
| nIterSigmaClipPtc = pexConfig.Field( | |||
| dtype=int, | |||
| doc="Number of sigma-clipping iterations for afwMath.StatisticsControl()", | |||
| default=1, | |||
| default=3, | |||
There was a problem hiding this comment.
Should changes to default values be recorded in a CHANGELOG of some sort, somewhere? Probably not, but at the very least, this should be in its own commit. Same goes for the change in L105.
Change sigma clip iter number to 1
Fix typo Remove SAT from default mask planes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.