DM-24762: Add option to PTC task to correct for sigma clipping bias #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,6 +273,11 @@ def run(self, inputExp, inputDims): | |||
| # in {maxLag, maxLag}^2] | |||
| muDiff, varDiff, covAstier = self.measureMeanVarCov(exp1, exp2, region=region, | |||
| covAstierRealSpace=doRealSpace) | |||
| # Correction factor for sigma clipping. Function returns 1/sqrt(varFactor), | |||
| # so it needs to be squared. varDiff is calculated via afwMath.VARIANCECLIP. | |||
| varFactor = sigmaClipCorrection(self.config.nSigmaClipPtc)**2 | |||
There was a problem hiding this comment.
I just want to check that L305 where you square things (as it was before) isn't re-squaring (i.e. because you're squaring the result here already).
Basically this line and the next are as they were before (I think) but it looks like L305 and L306 might be expecting it not to be squared, so just check that's all consistent.
Definitely not saying this is wrong, but just check this is really what you want.
There was a problem hiding this comment.
We actually have two ways of getting the variance of the difference image: via afwMath.VARIANCECLIP and via the [0,0] element of the covariance calculation (Pierre’s code; L305, and L306). So that’s why the squaring was done in two different places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.