tickets/DM-15756 Fix biasCorr code and default params #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This operation is, as now documented, clearly not appropriate when the function is being used to calculate the bias.
PaulPrice
approved these changes
Dec 18, 2018
| DM-15756 is done as these should agree). | ||
| Then calculate the bias induced using the cross-correlation image and the | ||
| image means. | ||
| using the task code and calculate the bias induced using |
There was a problem hiding this comment.
Remove "using the task code"?
There was a problem hiding this comment.
Good point, thanks!
Now that the task code agrees with the sim code, remove it, its uses, and update docs to reflect its removal.
mfisherlevine
force-pushed
the
tickets/DM-15756
branch
from
418b909
to
c80c077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.