DM-22534: Implement cpSkyTask #88
Conversation
| CpSkyScaleMeasure | ||
| ################# | ||
|
|
||
| ``CpSkyScaleMeasure`` merges the `lsst.pipe.drivers.FocalPlaneBackground` models generated per-detector into single full-focal plane model. |
There was a problem hiding this comment.
The description for this doesn't seem to capture its primary objective, i.e., the measurement of per-exposure scale factors. Could you add this into the description here?
Minor typo: "into single" > "into a single"
| CpSkySubtractBackground | ||
| ####################### | ||
|
|
||
| ``CpSubtractBackground`` subtracts the scaled full-focal plane model created by :lsst-task:`~lsst.cp.pipe.CpSkyScaleMeasureTask` from the per-detector images created by :lsst-task:`~lsst.cp.pipe.CpSkyImageTask`. |
There was a problem hiding this comment.
Should this be 'CpSkySubtractBackground'?
| Processing summary | ||
| ================== | ||
|
|
||
| ``CpSubtractBackground`` runs these operations: |
There was a problem hiding this comment.
^^^ 'CpSkySubtractBackground'
python/lsst/cp/pipe/cpSkyTask.py
Outdated
|
|
||
| largeScaleBackground = pexConfig.ConfigField( | ||
| dtype=FocalPlaneBackgroundConfig, | ||
| doc="Large-scale background configuration", |
python/lsst/cp/pipe/cpSkyTask.py
Outdated
| # self.largeScaleBackground.xSize = 256 | ||
| # self.largeScaleBackground.ySize = 256 |
There was a problem hiding this comment.
Why are these inline comments necessary? Are they hinting at recommended defaults? They don't seem to correspond to the obs_subaru values below (8192 x 8192 pixels).
There was a problem hiding this comment.
I've removed the 256 comments, and clarified the obs_subaru comment. As these values are not completely intuitive (very few other places in the code use mm), I wanted to note where they came from.
python/lsst/cp/pipe/cpSkyTask.py
Outdated
| else: | ||
| self.maskTask.run(inputExp, self.config.maskList) | ||
|
|
||
| # As constructCalibs.py SkyTask.measureBackground() |
czwa
force-pushed
the
tickets/DM-22534
branch
from
38db02e
to
297bba3
Compare
This also removes Latiss specific configs from the base pipeline definition.
This ticket re-implements pipe_drivers constructCalib.py SkyTask in gen3, using four tasks to handle the map-reduce-map-reduce structure of the old code.