DM-30257: Remove eotest dependency from cp_pipe #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
The change, as it is, looks totally fine.
The only thing I do wonder is whether we should just leave the file as-is, and either remove the warning altogether, or shove it down to DEBUG or TRACE level, but I guess we want to reduce cruft, and should we ever decide to resurrect this, we can always just pull it out of the git history, so yeah, on balance I think this is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove runEotestTask.