Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-29981: Migrate cp_pipe pipelines as defined in RFC-775 #95

Merged
merged 10 commits into from Jul 22, 2021
Merged

DM-29981: Migrate cp_pipe pipelines as defined in RFC-775 #95

merged 10 commits into from Jul 22, 2021

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Jul 21, 2021

Add per-camera pipeline definitions that inherit from the base definitions.

@czwa czwa requested a review from mrawls July 21, 2021 00:58
mrawls
mrawls reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things to fix, but generally looks great. Please consider squashing some commits, perhaps one per camera would be appropriate?

pipelines/Latiss/findDefects.yaml Show resolved Hide resolved
pipelines/Latiss/findDefectsPostFlat.yaml Show resolved Hide resolved
pipelines/Latiss/cpBfkSolve.yaml Outdated Show resolved Hide resolved
pipelines/LsstCamImSim/cpPtc.yaml Outdated Show resolved Hide resolved
pipelines/LsstComCam/cpPtc.yaml Outdated Show resolved Hide resolved
@czwa czwa merged commit b17765a into master Jul 22, 2021
@czwa czwa deleted the tickets/DM-29981 branch July 22, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrawls mrawls mrawls left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czwa @mrawls