Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-29326: Fix logic of the doVignette option in isrTask #11

Merged
merged 2 commits into from Dec 1, 2021

Conversation

czwa
Copy link
Collaborator

@czwa czwa commented Nov 19, 2021

I missed a vignette case here.

This also fixes a new build error related to scipy.

@czwa czwa requested a review from plazas November 19, 2021 23:03
Copy link
Contributor

@plazas plazas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry I missed it the first time too. I looked for more instances of vignetteExposure and it seems that there are not more.

@czwa czwa merged commit 696d8ea into main Dec 1, 2021
@czwa czwa deleted the tickets/DM-29326 branch December 1, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants