DM-30170: Define crosstalk tests for cp_verify #15
Conversation
python/lsst/cp/verify/verifyCalib.py
Outdated
| """ | ||
| outputStats = {} | ||
|
|
||
| outputStats['DETECTOR'] = self.detectorStatistics(inputCalib) |
There was a problem hiding this comment.
I don't see how this could create a dict that resolves to the yaml described in the docstring. Roots would be DETECTOR, VERIFY, SUCCESS, and not AMP, DET, CATALOG.
There was a problem hiding this comment.
Also below there's something about N_VALID?
There was a problem hiding this comment.
This is a copy from the CpVerifyStatsTask block, and I forgot to clean it up to match reality. I've removed the entries that do not exist, and renamed DETECTOR to DET to match how verifyStats names things. N_VALID is one of the STAT entries, and I've updated the text to note that.
| VERIFY_SIGMA: boolean | ||
| DetectorId2: | ||
| [...] | ||
| MEAN_UNIMODAL: boolean |
There was a problem hiding this comment.
Where do these UNIMODAL values come from?
There was a problem hiding this comment.
That was me confusing myself by copying a docstring and incompletely editing it. The new docstring now represents what is actually constructed, and use generic TEST_VALUE style names.
Add task to run validation against a calibration instead of against processed exposures, and subclass that for crosstalk.
Add unit test and example notebooks.