Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34867: Add cp_verify tests for quick gain measurement #20

Merged
merged 10 commits into from Sep 28, 2022

Conversation

plazas
Copy link
Contributor

@plazas plazas commented Sep 27, 2022

No description provided.

@plazas plazas requested a review from czwa September 27, 2022 18:57
Copy link
Collaborator

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just docstrings issues here.

----------
inputCalib : `lsst.ip.isr.IsrCalib`
The calibration to verify.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docstring needs to be updated with the new parameters.

----------
inputCalib : `lsst.ip.isr.IsrCalib`
The calibration to verify.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well.

the mostly likely types).
camera : `lsst.afw.cameraGeom.Camera`, optional
Input camera to get detectors from.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

@plazas plazas merged commit 090253a into main Sep 28, 2022
@plazas plazas deleted the tickets/DM-34867 branch September 28, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants