DM-30174: Define linearity tests for cp_verify #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plazas
force-pushed
the
tickets/DM-30174
branch
from
cf65c89
to
589274d
Compare
czwa
approved these changes
Feb 21, 2023
| doc="Expected amplitude of second-order non-linearity coefficient, if polynomial.", | ||
| default=1e-6, | ||
| ) | ||
| maxResidualThresoldTable = pexConfig.Field( |
There was a problem hiding this comment.
Typo in Threshold. There's probably a matching one below.
| outputStatistics : `dict` [`str`, scalar] | ||
| A dictionary of the statistics measured and their values. | ||
| """ | ||
| calibMetadata = inputCalib.getMetadata().toDict() |
There was a problem hiding this comment.
You can access elements directly from the metadata, so there's no need to convert to a dict here.
| """ | ||
| verifyStats = {} | ||
| success = True | ||
| calibMetadata = calib.getMetadata().toDict() |
| # signal | ||
| delta = calib.tableData[indexTableAmp, :][1:] / indices | ||
| maxError = np.max(np.abs(delta)) | ||
| verify['MAX_RESIDUAL_ERROR'] = bool(maxError <= self.config.maxResidualThresoldTable) |
Fix flake 8 errors
Fix linter errors. Fix typos.
Fix linter error.
plazas
force-pushed
the
tickets/DM-30174
branch
from
589274d
to
9873472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.