Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38569: Move cp_verify notebooks out of examples/ #24

Merged
merged 4 commits into from Apr 13, 2023
Merged

DM-38569: Move cp_verify notebooks out of examples/ #24

merged 4 commits into from Apr 13, 2023

Conversation

czwa
Copy link
Collaborator

@czwa czwa commented Apr 5, 2023

As part of this ticket, I've also updated the notebooks to use the updated style. They have also been more fully parameterized, and should work with papermill.

@czwa czwa requested a review from plazas April 11, 2023 17:27
plazas
plazas approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@plazas plazas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebooks have been moved to a new location, as per the ticket requests. I have asked for clarification in the comments that how to use papermill, and the addressing of minor bugs, reported in Jira, before merging.

@czwa czwa merged commit e478d71 into main Apr 13, 2023
2 checks passed
@czwa czwa deleted the tickets/DM-38569 branch April 13, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plazas plazas plazas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czwa @plazas