DM-39212: Move no-instrument pipelines in cp_pipe to an "ingredients" directory #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again @czwa, these look good. As with |
leeskelvin
approved these changes
May 24, 2023
leeskelvin
reviewed
May 24, 2023
pipelines/_ingredients/README.md
Outdated
| used directly by end-users for science purposes. | ||
|
|
||
| Science ready pipeline definitions for specific cameras are located in | ||
| the [pipelines](../pipelines) directory. |
There was a problem hiding this comment.
I think this just needs to be [pipelines](..) to link properly. Whilst you're formatting, would it be possible to have one sentence per line?
leeskelvin
reviewed
May 24, 2023
pipelines/README.md
Outdated
| characteristics of that camera. | ||
|
|
||
| The pipelines defined here tend to import other pipelines, including | ||
| ingredient pipelines in the [_ingredients](./_ingredients) directory. |
There was a problem hiding this comment.
This can just be [_ingredients](_ingredients) I think. I'd also recommend one line per sentence in this file too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move pipeline defaults to ingredients directory.