DM-38563: Compare LATISS Defects generated from combined images #31
Conversation
| name="camera", | ||
| storageClass="Camera", | ||
| doc="Input camera.", | ||
| dimensions=[ |
There was a problem hiding this comment.
I'm not to concerned about which formatting style we use, but it should be consistent.
There was a problem hiding this comment.
Agree; this was probably a consequence of running black.
| "UNC_MIN": "MIN", | ||
| "UNC_MAX": "MAX", | ||
| } | ||
| # initialize the dictionaries. They will get replaced. |
There was a problem hiding this comment.
Can you add something about "These config options need to have a key/value pair to run verification analysis, but the contents of that pair are not used"? I'm sure I'll be confused next time I read this bit of code, and that should help.
| ConfigClass = CpVerifyDefectsConfig | ||
| _DefaultName = 'cpVerifyDefects' | ||
| _DefaultName = "cpVerifyDefects" |
There was a problem hiding this comment.
Thank you for clearing up my inconsistent use of ' and ". It's the same as the formatting issue, and I know I'm consistently inconsistent.
| if verifyStatsCat["SUCCESS"] is False: | ||
| successCat = False | ||
|
|
||
| success = successDet & successAmp & successCat |
There was a problem hiding this comment.
I'm not convinced successAmp needs to be included, but if it doesn't cause problems, there's no reason to remove it, I think.
python/lsst/cp/verify/verifyStats.py
Outdated
| @@ -67,10 +75,11 @@ class CpVerifyStatsConnections(pipeBase.PipelineTaskConnections, | |||
| name="camera", | |||
| storageClass="Camera", | |||
| doc="Input camera.", | |||
| dimensions=["instrument", ], | |||
| dimensions=[ | |||
Add comment and fix formatting
Fix flake8 error
plazas
force-pushed
the
tickets/DM-38563
branch
from
4c3d933
to
ff957ec
Compare
No description provided.