DM-33557: Add cp_verify tests to ci_cpp #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
czwa
commented
Nov 2, 2023
czwa
commented
- Fix PTC verify results not being writable to yaml
- Remove unneeded photodiode connection.
- Disable PSF measurement in brighter-fatter verification. Switch shape measurement used.
- Ensure the correct linearity model is used.
DM-38944 removed this connection on the main cp_pipe version of the linearizer task, but the subclass here was forgotten.
czwa
force-pushed
the
tickets/DM-33557
branch
from
0d5b0d1
to
1b4f318
Compare
erykoff
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.