Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42238: Add a check of consistency whether the noise measurements from the PTC fit and the overscan #35

Merged
merged 1 commit into from Feb 2, 2024
Merged

DM-42238: Add a check of consistency whether the noise measurements from the PTC fit and the overscan #35

merged 1 commit into from Feb 2, 2024

Conversation

Alex-Broughton
Copy link
Contributor

…verscan

youtsumi
youtsumi reviewed Jan 20, 2024
View reviewed changes
Copy link

@youtsumi youtsumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a few comments.

python/lsst/cp/verify/verifyPtc.py Outdated Show resolved Hide resolved
python/lsst/cp/verify/verifyPtc.py Outdated Show resolved Hide resolved
python/lsst/cp/verify/verifyPtc.py Outdated Show resolved Hide resolved
czwa
czwa approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github comment at the bottom can be resolved by removing the "---" line it complains about. This may have been done by another ticket before you get to it, though, so it may disappear after rebasing.

python/lsst/cp/verify/verifyPtc.py Outdated Show resolved Hide resolved
python/lsst/cp/verify/verifyPtc.py Outdated Show resolved Hide resolved
@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-42238 branch 2 times, most recently from b36c416 to 1dcceeb Compare January 29, 2024 20:48
@Alex-Broughton Alex-Broughton changed the title Add test case to compare PTC noise fit and measured read noise from o… DM-42238: Add a check of consistency whether the noise measurements from the PTC fit and the overscan Feb 1, 2024
@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-42238 branch 2 times, most recently from 5fe3cb1 to d388a5d Compare February 1, 2024 21:42
@Alex-Broughton Alex-Broughton merged commit 6917e70 into main Feb 2, 2024
3 checks passed
@Alex-Broughton Alex-Broughton deleted the tickets/DM-42238 branch February 2, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtsumi youtsumi youtsumi left review comments

@plazas plazas plazas left review comments

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Alex-Broughton @youtsumi @plazas @czwa