DM-42643: Pre-process data into catalog format for analysis_tools #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-42643
branch
from
964e512
to
95ae809
Compare
sr525
reviewed
Jan 25, 2024
|
|
||
| def repackRunStats(self, runStats): | ||
| # for runStats in runStats: | ||
| raise NotImplementedError("Repack needs to be defined by subclasses.") |
There was a problem hiding this comment.
Are repackExpStats and repackRunStats used anywhere? It looks like it is just repackDetStats.
There was a problem hiding this comment.
They are not, but I wanted to be able to access them in the future if they became useful.
czwa
force-pushed
the
tickets/DM-42643
branch
from
95ae809
to
a4eaa7d
Compare
erykoff
reviewed
Jan 25, 2024
| def runQuantum(self, butlerQC, inputRefs, outputRefs): | ||
| inputs = butlerQC.get(inputRefs) | ||
|
|
||
| inputs["detectorDims"] = [exp.dataId.byName() for exp in inputRefs.detectorStats] |
There was a problem hiding this comment.
This should be dict(exp.dataId.required) instead of exp.dataId.byName()
There was a problem hiding this comment.
That explains the warnings I'm seeing. I'm going to wait for the next ticket to fix this, as I have been struggling to get this ticket to pass Jenkins for the merge.
erykoff
reviewed
Jan 25, 2024
| def runQuantum(self, butlerQC, inputRefs, outputRefs): | ||
| inputs = butlerQC.get(inputRefs) | ||
|
|
||
| inputs["detectorDims"] = [exp.dataId.byName() for exp in inputRefs.detectorStats] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.