DM-42159: eo_pipe/cp_verify parity: bias #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
force-pushed
the
tickets/DM-42159
branch
from
5377022
to
fa90d7f
Compare
erykoff
approved these changes
Jan 25, 2024
python/lsst/cp/verify/verifyBias.py
Outdated
| # Docstring inherited | ||
| outputStatistics = super().imageStatistics(exposure, uncorrectedExposure, statControl) | ||
|
|
||
| # These should be a config item, probably. |
There was a problem hiding this comment.
You mean the statistic as well as the box size? Either fix this or remove the comment.
There was a problem hiding this comment.
Just the box size. I've removed the comment as it needed to be made a config to pass the unit tests (the default box size is too large for the mocked image).
czwa
force-pushed
the
tickets/DM-42159
branch
from
c35abc7
to
ad08bb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket adds: