Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42165: eo_pipe/cp_verify parity: bfk #40

Merged
merged 7 commits into from Jan 31, 2024
Merged

DM-42165: eo_pipe/cp_verify parity: bfk #40

merged 7 commits into from Jan 31, 2024

Conversation

plazas
Copy link
Contributor

@plazas plazas commented Jan 29, 2024

No description provided.

@plazas plazas requested a review from czwa January 29, 2024 19:54
czwa
czwa previously approved these changes Jan 29, 2024
Copy link
Collaborator

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit approve before rereading the ticket: this also needs to add the x-corr/y-corr slopes, doesn't it? Those should be simple linear fits to {flux, cov10} and {flux, cov01}.

@czwa czwa dismissed their stale review January 29, 2024 21:38

I was wrong.

Copy link
Collaborator

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covariance slopes are missing.

@plazas
Copy link
Contributor Author

plazas commented Jan 30, 2024

I hit approve before rereading the ticket: this also needs to add the x-corr/y-corr slopes, doesn't it? Those should be simple linear fits to {flux, cov10} and {flux, cov01}.

Sorry for missing those, I thought we wanted to calculate them in analysis tools. The most recent commit adds these parameters.

@plazas plazas merged commit cd109a9 into main Jan 31, 2024
3 checks passed
@plazas plazas deleted the tickets/DM-42165 branch January 31, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants