Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42732: Add missing bias shift data #43

Merged
merged 3 commits into from Feb 22, 2024
Merged

DM-42732: Add missing bias shift data #43

merged 3 commits into from Feb 22, 2024

Conversation

czwa
Copy link
Collaborator

@czwa czwa commented Feb 21, 2024

This also adds the updated amp correlation results.

* Update returns to use Struct.
* Add second output product.
* Tidy dimension lists.
Copy link

@enourbakhsh enourbakhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would it be useful to unit test these changes?

@czwa
Copy link
Collaborator Author

czwa commented Feb 22, 2024

Looks good. Would it be useful to unit test these changes?

I've linked this ticket to DM-42661, which will fix a number of similar issues that were brought up by the sprint. That ticket will update the target result files that are produced by ci_cpp and re-enable the test that compares those targets to the files that are generated by the pipelines.

@czwa czwa merged commit eda5c37 into main Feb 22, 2024
3 checks passed
@czwa czwa deleted the tickets/DM-42732 branch February 22, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants