DM-31721: Rename package to cpputils #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
changed the title
timj
force-pushed
the
tickets/DM-31721
branch
from
84854bc
to
439e4d8
Compare
This package is the utils package but with all the python-only code removed from it. What remains is the C++ code and the pybind11 interfaces to that code.
timj
force-pushed
the
tickets/DM-31721
branch
from
439e4d8
to
0358688
Compare
This makes it possible for C++ applications that previously used the utils C++ code to still use it without modification. Changing to lsst::cpputils requires all the code to change because of the complexity of forwarding namespaces from the utils package to the cpputils package through a deprecation period.
ktlim
approved these changes
Sep 17, 2021
ups/cpputils.cfg
Outdated
| @@ -9,6 +9,6 @@ dependencies = { | |||
|
|
|||
| config = lsst.sconsUtils.Configuration( | |||
| __file__, | |||
| headers=["lsst/utils/Utils.h"], | |||
| headers=["lsst/cpputils/Utils.h"], | |||
There was a problem hiding this comment.
This doesn't look right. I'm surprised Jenkins worked. Although it would work if you install the symlinks mentioned above.
There was a problem hiding this comment.
definitely all passed. I don't really understand what that line does because Utils.h is formally deprecated.
There was a problem hiding this comment.
I removed Utils.h completely and put packaging.h in there instead. I also adjusted afw to stop using Utils.h.
This reverts commit aae2ac6.
timj
force-pushed
the
tickets/DM-31721
branch
from
a9b0f98
to
a44d6b6
Compare
This allows legacy code to still look for lsst::utils A symlink is used per file. This makes it explicit which include files are supporting deprecation. Also, directory symlinks are not currently supported by sconsUtils install.
Has not been used for 3 years since DM-10384.
timj
force-pushed
the
tickets/DM-31721
branch
from
a44d6b6
to
82ae60c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is the utils package but with all the python-only code
removed from it (see lsst/utils#97). What remains is the C++ code and the pybind11
interfaces to that code.