Skip to content

Commit

Permalink
Don't set job retries on the DAG level
Browse files Browse the repository at this point in the history
Besides setting the number of retries on a job level (in the job
submission file) they were also set in DAGMan submission file.  Fixed
it.
  • Loading branch information
mxk62 committed Sep 1, 2021
1 parent 154344c commit 1b49c8a
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions python/lsst/ctrl/bps/wms/htcondor/htcondor_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,9 @@ def _translate_job_cmds(config, generic_workflow, gwjob):
if gwjob.number_of_retries:
jobcmds["max_retries"] = f"{gwjob.number_of_retries}"

if gwjob.retry_unless_exit:
jobcmds["retry_until"] = f"{gwjob.retry_unless_exit}"

if gwjob.request_disk:
jobcmds["request_disk"] = f"{gwjob.request_disk}MB"

Expand Down Expand Up @@ -532,9 +535,7 @@ def _translate_dag_cmds(gwjob):
DAGMan commands for the job.
"""
# Values in the dag script that just are name mappings.
dag_translation = {"number_of_retries": "retry",
"retry_unless_exit": "retry_unless_exit",
"abort_on_value": "abort_dag_on",
dag_translation = {"abort_on_value": "abort_dag_on",
"abort_return_value": "abort_exit"}

dagcmds = {}
Expand Down

0 comments on commit 1b49c8a

Please sign in to comment.