Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33521: Split plugins out of ctrl_bps #102

Merged
merged 9 commits into from Apr 25, 2022
Merged

DM-33521: Split plugins out of ctrl_bps #102

merged 9 commits into from Apr 25, 2022

Conversation

mxk62
Copy link
Contributor

@mxk62 mxk62 commented Apr 20, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #102 (2973b68) into main (c102962) will increase coverage by 21.71%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #102       +/-   ##
===========================================
+ Coverage   25.39%   47.11%   +21.71%     
===========================================
  Files          46       29       -17     
  Lines        3993     1974     -2019     
  Branches      713      319      -394     
===========================================
- Hits         1014      930       -84     
+ Misses       2957     1023     -1934     
+ Partials       22       21        -1     
Impacted Files Coverage Δ
python/lsst/ctrl/bps/wms_service.py 78.87% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c102962...2973b68. Read the comment docs.

Copy link
Collaborator

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran tests with the HTCondor and PanDA plugins successfully. Just some minor comments/questions mostly about the documentation.

doc/lsst.ctrl.bps/quickstart.rst Outdated Show resolved Hide resolved
doc/lsst.ctrl.bps/quickstart.rst Outdated Show resolved Hide resolved
doc/lsst.ctrl.bps/quickstart.rst Outdated Show resolved Hide resolved
@mxk62 mxk62 merged commit 1c4f7c9 into main Apr 25, 2022
@mxk62 mxk62 deleted the tickets/DM-33521 branch April 25, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants