Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37044: Add ability to specify computeSite on the CLI #124

Merged
merged 1 commit into from Nov 21, 2022

Conversation

leeskelvin
Copy link
Contributor

@leeskelvin leeskelvin commented Nov 18, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@leeskelvin leeskelvin force-pushed the tickets/DM-37044 branch 5 times, most recently from 296dc1e to 681cabf Compare November 18, 2022 18:44
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 77.06% // Head: 77.12% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (c3ce3e1) compared to base (4116043).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   77.06%   77.12%   +0.05%     
==========================================
  Files          39       39              
  Lines        2734     2741       +7     
  Branches      412      412              
==========================================
+ Hits         2107     2114       +7     
  Misses        552      552              
  Partials       75       75              
Impacted Files Coverage Δ
python/lsst/ctrl/bps/drivers.py 30.36% <ø> (ø)
python/lsst/ctrl/bps/cli/cmd/commands.py 88.23% <100.00%> (+1.13%) ⬆️
python/lsst/ctrl/bps/cli/opt/options.py 100.00% <100.00%> (ø)
tests/test_cli_commands.py 93.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. This should be added to the submit's command line documentation (doc/lsst.ctrl.bps/quickstart.rst). The restart as well although this one is a little trickier because some plugins save the compute site in files during prepare. So maybe on the restart add text like (consult WMS plugin documentation to see if it supports setting computeSite for restart) Merge is approved.

@leeskelvin leeskelvin merged commit 2c8ffc5 into main Nov 21, 2022
@leeskelvin leeskelvin deleted the tickets/DM-37044 branch November 21, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants