DM-34915: Add traversal of GenericWorkflow by job label. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 77.08% // Head: 78.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 77.08% 78.43% +1.34%
==========================================
Files 39 39
Lines 2736 2856 +120
Branches 412 415 +3
==========================================
+ Hits 2109 2240 +131
+ Misses 552 540 -12
- Partials 75 76 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mxk62
approved these changes
Jan 24, 2023
| @@ -394,21 +395,36 @@ def quanta_counts(self): | |||
| qcounts += gwjob.quanta_counts | |||
| return qcounts | |||
|
|
|||
| @property | |||
| def labels(self): | |||
| """List of job labels""" | |||
There was a problem hiding this comment.
Can we specify property type, i.e., append
(`list` [`str`], read-only)
to the existing doctring?
| gwjob = self.get_job(job_name) | ||
| jcounts[gwjob.label] += 1 | ||
| for job_label in self._labels: | ||
| jcounts[job_label] = len(self._labels[job_label]) |
There was a problem hiding this comment.
If I got it right, the logic in lines 419-421 could be expressed as
jcounts = Counter({label: len(jobs) for label, jobs in self._labels.items()})
which may be IMHO somewhat easier to follow.
MichelleGower
force-pushed
the
tickets/DM-34915
branch
from
e86540a
to
56b8137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes