DM-27575: fix requestMemory and matching glidein nodes. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requestMemory problem * Code was expecting request_memory instead of requestMemory in the yaml file. Fixed to expect requestMemory. * Code expected integers, but example config still showed as string (2GB). Fixed example in docs. * Code got back string from BpsConfig and needed to cast to int. * Pegasus plugin was missing code to use these values. matching glidein nodes Code existed in the Pegasus plugin and works. Added code to the HTCondor plugin to allow pass through values. Added example config lines to the docs. The --init-only job did not have any code to pick up either of these settings, so added it. Minor changes: * Moved sample config from docs to separate file that is included in docs. Easier to copy it for use that way. * Fixed other snake case config keys to camel case that were missed previously. * Added output stream to one write->print previously changed in the Pegasus plugin that was missed.
mxk62
approved these changes
Nov 18, 2020
| PEGASUS_HOME: /usr/local/pegasus/current | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
I'm not sure if it's a requirement, but by convention titles and section headings are set off from surrounding text by
a single blank line above and below.
doc/lsst.ctrl.bps/quickstart.rst
Outdated
| profile: | ||
| condor: | ||
| requirements: "(GLIDEIN_NAME == "test_gname")" | ||
| +GLIDEIN_NAME: "test_gname" |
There was a problem hiding this comment.
To my understanding, the provided example is a part of the description of the site setting. For that reason, I would expect the code block be indented as the description text is.
The LSST Dev Guide says [src]:
ReStructuredText should be indented consistently with the context
doc/lsst.ctrl.bps/quickstart.rst
Outdated
| dagman: | ||
| retry: 0 | ||
| env: | ||
| PEGASUS_HOME: /usr/local/pegasus/current |
|
As a general comment we don't require camel case in YAML configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestMemory problem
in the yaml file. Fixed to expect requestMemory.
string (2GB). Fixed example in docs.
matching glidein nodes
Code existed in the Pegasus plugin and works. Added code to
the HTCondor plugin to allow pass through values. Added
example config lines to the docs.
The --init-only job did not have any code to pick up either of
these settings, so added it.
Minor changes:
in docs. Easier to copy it for use that way.
missed previously.
in the Pegasus plugin that was missed.