Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38418: Override get method in BpsConfig to make default value parameter work #136

Merged
merged 2 commits into from Mar 23, 2023

Conversation

mxk62
Copy link
Contributor

@mxk62 mxk62 commented Mar 23, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12 🎉

Comparison is base (b2e9cf8) 78.43% compared to head (f028e0a) 78.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   78.43%   78.55%   +0.12%     
==========================================
  Files          39       39              
  Lines        2856     2872      +16     
  Branches      490      490              
==========================================
+ Hits         2240     2256      +16     
  Misses        540      540              
  Partials       76       76              
Impacted Files Coverage Δ
python/lsst/ctrl/bps/bps_config.py 94.77% <100.00%> (+0.11%) ⬆️
tests/test_bpsconfig.py 98.23% <100.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation matches expectations. Just two minor comments about a docstring and some comments about unit tests. Merge approved.

python/lsst/ctrl/bps/bps_config.py Outdated Show resolved Hide resolved
tests/test_bpsconfig.py Show resolved Hide resolved
python/lsst/ctrl/bps/bps_config.py Outdated Show resolved Hide resolved
@mxk62 mxk62 merged commit d08cb7c into main Mar 23, 2023
10 checks passed
@mxk62 mxk62 deleted the tickets/DM-38418 branch March 23, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants