Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38469: Remove read_quantum_graph method. #137

Merged
merged 1 commit into from Mar 29, 2023
Merged

Conversation

MichelleGower
Copy link
Collaborator

@MichelleGower MichelleGower commented Mar 29, 2023

Call QuantumGraph.loadUri() directly as passing of butler repository's DimensionUniverse is no longer needed.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Call QuantumGraph.loadUri() directly as passing of butler
repository's DimensionUniverse is no longer needed.
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.10 🎉

Comparison is base (d08cb7c) 78.55% compared to head (1cd7976) 78.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   78.55%   78.65%   +0.10%     
==========================================
  Files          39       39              
  Lines        2872     2863       -9     
  Branches      490      489       -1     
==========================================
- Hits         2256     2252       -4     
+ Misses        540      535       -5     
  Partials       76       76              
Impacted Files Coverage Δ
python/lsst/ctrl/bps/pre_transform.py 46.05% <0.00%> (+1.47%) ⬆️
python/lsst/ctrl/bps/quantum_clustering_funcs.py 99.20% <ø> (ø)
python/lsst/ctrl/bps/clustered_quantum_graph.py 56.54% <50.00%> (-0.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichelleGower MichelleGower marked this pull request as ready for review March 29, 2023 18:21
@MichelleGower MichelleGower changed the title Remove read_quantum_graph method. DM-38469: Remove read_quantum_graph method. Mar 29, 2023
@MichelleGower MichelleGower merged commit 80bbc1b into main Mar 29, 2023
9 of 10 checks passed
@MichelleGower MichelleGower deleted the tickets/DM-38469 branch March 29, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants