Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38138: Create a build task for remote submission #138

Merged
merged 3 commits into from Apr 3, 2024

Conversation

zhaoyuyoung
Copy link

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj changed the title create a build task for remote submission DM-38138: Create a build task for remote submission Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 77.86%. Comparing base (8a6235f) to head (83186a3).

Files Patch % Lines
python/lsst/ctrl/bps/drivers.py 0.00% 22 Missing ⚠️
python/lsst/ctrl/bps/submit.py 9.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   78.44%   77.86%   -0.58%     
==========================================
  Files          40       40              
  Lines        3099     3122      +23     
  Branches      529      536       +7     
==========================================
  Hits         2431     2431              
- Misses        578      601      +23     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config = BpsConfig(config_file, BPS_SEARCH_ORDER)
_, remote_build = config.search("remoteBuild", opt={"default": {}})
if remote_build:
if config["wmsServiceClass"] == "lsst.ctrl.bps.panda.PanDAService":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichelleGower Comments? Adding anything to bps that wants to know about a plugin seems wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to look at this yet other than this one line. What @timj says is correct. There shouldn't be a need to write WMS specific code inside ctrl_bps. If we're wanting to do all of the bps submission stages remotely or let's make that more generic to inside a compute job (even a local job), then we should change the bps code generically to do this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree. At the time when we worked on the remote submission, it's not a generic operation for other WMS, so we tried to keep other WMS intact but only apply the remote submission to PanDA. Basically we need bps has a way to stop generating quantum graph and execution bulter at the stage of transform when it's a remote submission.

@wguanicedew wguanicedew marked this pull request as ready for review April 3, 2024 14:11
@wguanicedew wguanicedew merged commit e01b512 into main Apr 3, 2024
12 of 14 checks passed
@wguanicedew wguanicedew deleted the tickets/DM-38138 branch April 3, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants