DM-39898: Use ResourcePath to read the bps defaults #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config supports reading of package resources directly so there is no need to find the local path to the resources in BPS itself. Also remove the __init__.py since the resources do not need it.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
- Coverage 78.72% 78.71% -0.02%
==========================================
Files 40 40
Lines 3093 3091 -2
Branches 519 518 -1
==========================================
- Hits 2435 2433 -2
Misses 568 568
Partials 90 90
☔ View full report in Codecov by Sentry. |
mxk62
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config supports reading of package resources directly so there is no need to find the local path to the resources in BPS itself. Also remove the init.py since the resources do not need it.
Checklist
doc/changes