DM-39553: Misc updates discovered when enabling QBB with ctrl_bps_panda #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 78.71% 78.73% +0.01%
==========================================
Files 40 40
Lines 3091 3089 -2
Branches 518 518
==========================================
- Hits 2433 2432 -1
+ Misses 568 567 -1
Partials 90 90
☔ View full report in Codecov by Sentry. |
BPS defaults are loaded by bps first thing. Loading them here would reset values modified by ctrl_bps_panda's configs or other user configs.
Replace runQgraphFile's submit directory path in command line with FILE placeholder to allow for staging qgraph to a non-submit location accessible from jobs (e.g., cloud storage).
While not causing problems, it doubled the inputs for pipetaskInit in the GenericWorkflow.
MichelleGower
force-pushed
the
tickets/DM-39553
branch
from
26ad0b2
to
d33a81f
Compare
MichelleGower
changed the title
mxk62
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes