DM-40025: Make QBB default behavior in ctrl_bps #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 78.73% 78.70% -0.03%
==========================================
Files 40 40
Lines 3089 3090 +1
Branches 518 519 +1
==========================================
Hits 2432 2432
- Misses 567 568 +1
Partials 90 90
☔ View full report in Codecov by Sentry. |
|
To fix doc build change the conf.py to use weekly rather than daily. |
When neither 'executionButlerTemplate' nor 'executionButlerDir' is set acquire_quantum_graph() will set the exection butler directory to run's submit directory. This will trick 'ctrl_bps_parsl' into using a non-existent execution butler and the run will fail. Added a simple safeguard to prevent such a situation.
mxk62
force-pushed
the
tickets/DM-40025
branch
from
1592616
to
153f292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes