DM-42127: Add htcondor support for bps report --return-exit-codes #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GenericWorkflow class has a property which provides the job count per task label. Made changes to ensure that the label ordering reflects the ordering of the pipetasks in the pipeline.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 78.47% 78.44% -0.04%
==========================================
Files 40 40
Lines 3108 3099 -9
Branches 530 529 -1
==========================================
- Hits 2439 2431 -8
Misses 578 578
+ Partials 91 90 -1 ☔ View full report in Codecov by Sentry. |
MichelleGower
approved these changes
Jan 30, 2024
| @@ -284,7 +284,7 @@ def compile_job_summary(jobs): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| jobs : `list` [`lsst.ctrl.bps.WmsRunReport`] | |||
| jobs : `list` [`lsst.ctrl.bps.WmsJobReport`] | |||
| List of run reports. | |||
There was a problem hiding this comment.
If changing type to WmsJobReport, then should the comment be "List of job reports."?
There was a problem hiding this comment.
Yes, it should. Will fix.
Previous version of the ExitCodesReport was assuming that the payload (pipetask) always exits with exit code 1 if case of any error. As a matter of fact, the pipetask can also exit with code 2 when any issues with the command line are encountered (e.g. bad command, option, etc.). Hence I added additional column to the exit code report which, similarly to infrastructure errors, will show what type payload errors happened during pipeline execution.
mxk62
force-pushed
the
tickets/DM-42127
branch
from
e39a22d
to
45fa4b3
Compare
Updated pre-commit config file to use the most recent Black.
mxk62
force-pushed
the
tickets/DM-42127
branch
from
45fa4b3
to
db93175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes