DM-28929: Allow non-string HTCondor attributes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update doc/conf.py to new version
Add a :no-inherited-members: option to the automodapi directive in
ctrl_bps/doc/lsst.ctrl.bps/index.rst to workaround bug.
Since having to test building the docs, included minor text changes:
Update pipeline syntax from ':' to '#' to match stack changes.
Fix one missed capitalization change (qgraph_file to qgraphFile).
timj
reviewed
Feb 23, 2021
tests/test_lssthtc.py
Outdated
| htcondor = None | ||
|
|
||
|
|
||
| @unittest.skipIf(not htcondor, "Warning: Missing HTCondor API. Skipping") |
There was a problem hiding this comment.
This is fine, although I think I'd prefer skipIf(htcondor is None, ...) to be explicit. You can also say:
@unittest.skipUnless(htcondor is not None, "...")
mxk62
approved these changes
Feb 23, 2021
| value : `str` | ||
| String that needs to have characters escaped. | ||
| value : `Any` | ||
| Value that needs to have characters escaped if string |
There was a problem hiding this comment.
Don't we need a period at the end of this sentence?
| else: | ||
| pval = value | ||
|
|
||
| print(f'+{key} = {pval}', file=stream) |
There was a problem hiding this comment.
Could you please add a brief comment here hinting why this check in necessary here? Since it is so "close" to identical check in htc_escape() it took me longer that I'd like to admit to figure out that they serve two different purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTCondor plugin's code assumed that attribute value was a string. But Walltime on NCSA's DAC cluster needs to be an integer. So this ticket fixed the plugin code. Also some unrelated doc changes.