DM-27666: Remove path from qgraph filename in command line. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"bpsUseShared: True" causes command lines to have full submit path on QuantumGraph filename. Defaults to False.
mxk62
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the short-term fix ticket that fixes a bug keeping htcondor jobs from using the qgraph file it staged. With the bug, it worked when there was a shared filesystem such that the job could access it in the submit location. The long-term changes to not put it in the command line at all in the GenericWorkflow, but instead leaving it for the WMS plugin to handle is in a different ticket. Tested with htcondor and pegasus plugins.
While discussing this change with the folks who needed it because they don't have a shared filesystem, discovered that setting the environment in the htcondor section of the BPS yaml also wasn't working. Since simple fix, just made the change in this ticket too.