DM-26397: Add explicit DAG export from ctrl_bps #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new command which effectively allows for exporting DAG, i.e., it will halt the submission preparation after writing the generic workflow to a file.
All modules were using the same, root, logger so the name of the module which emitted a given log message was not being included in the message. Modified the modules to use their own loggers instead.
The driver function for pre-trasnform activities was slightly confusing as it also was responsible for clustering quanta -- an activity which happens _after_ pre-transform steps encapsulated by the corresponding API function. To separate these concerns I created a dedicated driver for clustering quanta.
The distinction between a high-level API function and a driver was rather blurred for the driver function responsible for printing out the run summary. Hence, I moved out the content of the driver to a separate function, report(), and made the driver call it instead.
MichelleGower
approved these changes
Jun 8, 2021
Added new commands: 'acquire' and 'cluster' which halt the submission process after acquiring (and persisting) the quantum graph and creating a clustered quantum graph, respectively.
Some of the doctrings were inaccurate. Fixed them.
Common argument in report() function and its driver were ordered differently than in cancel(). I reordered them to match the order in cancel().
Added a brief note to ``bps --help`` to help users distinguished between "basic" and "advanced" commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.