DM-29007: Lazy command line creation. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxk62
approved these changes
Jun 29, 2021
python/lsst/ctrl/bps/bps_config.py
Outdated
| default = None | ||
| if "default" in opt: | ||
| default = opt["default"] | ||
| opt["default"] = "" |
There was a problem hiding this comment.
If temporarily removing default from opt would also work, you may consider replacing lines 265-268 with default = opt.pop("default, None).
MichelleGower
force-pushed
the
tickets/DM-29007
branch
from
f487f57
to
aca4e3e
Compare
Environment variable specification inside jobs is WMS dependent. Also, file paths vary based upon which machines are sent the jobs by the WMS and where the WMS stages some files. Thus these variable expansions/replacements are best left to the WMS plugin. Polish code changes. * Updated quick start guide with pipetask command line changes. * Fixed BpsConfig unit test that changes had broken. * Finished/fixed some docstrings. * Made some more quotations marks consistent (single vs double). Update code per review. * Change multiple lines with single call to pop().
MichelleGower
force-pushed
the
tickets/DM-29007
branch
from
620de41
to
c948772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postpone creation of command line to the plugin. Added special GenericWorkflowJob cmdline syntax placeholders ENV:name and FILE:name as these are easier to distinguish from the other normal f-string placeholders.