DM-31043: Update ctrl_bps setup.cfg with flake8's max-doc-length=79 #37
Conversation
There was a problem hiding this comment.
Thanks for cleaning up a bunch of other stuff along the way. It looks like some spots were missed. I didn't comment on many of them in the code diff. In particular, check the tests and the import lines (in particular the from X import Y ones) to finish making all of them relative. Here are some find+grep commands I was doing to help check:
find . -type f ( -iname ".py" ! -name "init.py" ) -exec grep -n -H "^from lsst.ctrl.bps" {} ;
find . -type f ( -iname ".py" ! -name "init.py" ) -exec grep -n -H " of " {} ; | grep " : "
find . -type f ( -iname ".py" ! -name "init.py" ) -exec grep -n -H -E "( .bps_|bps.bps_)" {} ;
find . -type f ( -iname ".py" ! -name "init.py" ) -exec grep -n -H -E "lsst.ctrl.[^b]" {} ;
find . -type f ( -iname "*.py" ! -name "init.py" ) -exec grep -n -H -E "lsst.ctrl.bps.wms_service" {} ;
Do one more pass with the find+grep and one more round of building docs and pipelines_check run and then please merge.
|
|
||
| Parameters | ||
| ---------- | ||
| config : `.bps_config.BpsConfig` | ||
| config : `lsst.ctrl.BpsConfig` |
There was a problem hiding this comment.
Missing ".bps"? (if not then all the others shouldn't have .bps in them either.)
| @@ -35,22 +37,23 @@ def single_quantum_clustering(config, qgraph, name): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| config : `~lsst.ctrl.bps.bps_config.BpsConfig` | |||
| config : `lsst.ctrl.bps.bps_config.BpsConfig` | |||
There was a problem hiding this comment.
Does this need "bps_config"?
| @@ -225,7 +240,7 @@ def split_dependencies_by_tasks(self, dependencies): | |||
| return dependencies_by_tasks | |||
|
|
|||
| def get_input_file(self, job_name): | |||
| """ Extracts the quantum graph file needed for a job | |||
| """Extract the quantum graph file needed for a job | |||
There was a problem hiding this comment.
Missed adding a period?
| # Use dictionary plus template format string to create name. | ||
| # To avoid key errors from generic patterns, use defaultdict | ||
| # Use dictionary plus template format string to create name. To avoid | ||
| # key errors from generic patterns, use defaultdict |
Some comments and docstings were exceeding maximal allowed length. Also, some type specifications for function/methods were using now deprecated (?) conventions. I reformatted these comments and docstrings to make them satisfy the LSST requirements.
The default search order for BpsConfig was defined in submit.py, a module implementing function responsible for run submissions. Moved the definition to bps_config.py as it seems like much better choice.
No description provided.