DM-31541: Change pipetaskInit job to not read full QuantumGraph #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function creating the job responsible for merging the execution Butler was raising an exception if some of job attributes were not specified in the configuration. Alter it to handle such cases gracefully.
mxk62
force-pushed
the
tickets/DM-31541
branch
from
b19eb74
to
186b759
Compare
MichelleGower
approved these changes
Sep 9, 2021
mxk62
force-pushed
the
tickets/DM-31541
branch
from
186b759
to
cdc164e
Compare
The memory autoscaling mechanism requires a hard memory limit to avoid jobs staying in the job queue indefinitely due to unsatisfied memory requirements. BPS was trying to determine this limit by querying available computational resources regardless whether the memory autoscaling was enabled or not and always complained if failed. I made changes to prevent it from pestering users about it when not really necessary.
mxk62
force-pushed
the
tickets/DM-31541
branch
from
cdc164e
to
9fd79cc
Compare
create_init_workflow() was rereading the quantum graph unnecessarily which might result in memory issues for large graphs. Modified the code to pass it directly from the caller instead.
mxk62
force-pushed
the
tickets/DM-31541
branch
from
9fd79cc
to
fb98551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.