DM-31944: Fix HTCondor plugin splitting single concurrency_limit #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use SET_JOB_ATTR to add the bps_* attributes to the .dag file. This means when dag is restarted it will still have the bps_* attributes and thus show up in bps report.
When exactly one concurrency_limit value, the bug was converting the value into a comma-separated list of characters. There was an inconsistency across the code about whether the value was guaranteed to be a list or not. Changed all code to treat it as string, because that is what was currently actually stored.
mxk62
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I was in that plugin, I also tried out SET_JOB_ATTR to save bps_* attributes to .dag file so that they still are in the classad after a manual condor_submit_dag restart.
Checklist
doc/changes