DM-31887: Execution Butler bug fixes plus making it the default behavior. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxk62
reviewed
Sep 29, 2021
| # because this is where the chaining is currently done | ||
| runQuantumCommand: "${CTRL_MPEXEC_DIR}/bin/pipetask {initPreCmdOpts} run -b {butlerConfig} -i {inCollection} -o {output} --output-run {outCollection} --qgraph {qgraphFile} --qgraph-id {qgraphId} --qgraph-node-id {qgraphNodeId} --clobber-outputs --init-only --register-dataset-types {extraInitOptions}" | ||
| # Notes: Declaring and chaining now happen within execution butler steps. | ||
| # This command no longer needs -o and must have # --extend-run. |
There was a problem hiding this comment.
A "leftover" # after joining the lines (between have and --extend-run)?
MichelleGower
force-pushed
the
tickets/DM-31887
branch
from
a46f8cc
to
d28672c
Compare
mxk62
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still testing and tracking down one more HTCondor plugin report bug. But can provide feedback on what's here so far.
Checklist
doc/changes