Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32047: Add a requestMemoryMax config in ctrl_bps #62

Merged
merged 3 commits into from Oct 28, 2021
Merged

Conversation

mxk62
Copy link
Contributor

@mxk62 mxk62 commented Oct 27, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

When memory scaling is enabled a job is removed from the job queue as
soon as the amount of memory it requests exceeds a given memory limit.
I altered the memory scaling mechanism to make it run a job one more
time in such a situation (if new run attempts are permitted) with the
memory allowable by the limit and remove the job from the queue
afterwards it fails due to insufficient memory anyway.
@mxk62 mxk62 changed the title Tickets/dm 32047 DM-32047: Add a requestMemoryMax config in ctrl_bps Oct 27, 2021
Copy link
Collaborator

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments about comments. Changes approved for merging.

doc/lsst.ctrl.bps/quickstart.rst Show resolved Hide resolved
doc/lsst.ctrl.bps/quickstart.rst Outdated Show resolved Hide resolved
doc/lsst.ctrl.bps/quickstart.rst Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/wms/htcondor/htcondor_service.py Outdated Show resolved Hide resolved
@mxk62 mxk62 force-pushed the tickets/DM-32047 branch 2 times, most recently from 2e3f38d to fadf008 Compare October 27, 2021 23:14
@mxk62 mxk62 merged commit 373c287 into master Oct 28, 2021
@mxk62 mxk62 deleted the tickets/DM-32047 branch October 28, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants