Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if using 1 as a default value will cause any confusion down the road with the exit 1 from the actual command. I was wondering if could use 128 instead, but haven't tested it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, exit code 1 is the "Catchall for general errors". It will be emitted if pipetask does not provide any exit code and there was not a signal which leads to the pipetask termination. If the program terminates beyond that two cases I would assign such a case to "undefined behavior" and classify as a general error. According to this: https://tldp.org/LDP/abs/html/exitcodes.html code 128 is the "Invalid argument to exit".