Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32657: Abort bps submission if submit-side run directory already exists #80

Merged
merged 2 commits into from Dec 6, 2021

Conversation

mxk62
Copy link
Contributor

@mxk62 mxk62 commented Dec 3, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Not all files in the submit-side directory are uniquely named.  Hence
using the same submit directory for multiple runs will cause problems.
Modify BPS to abort a submission if the run directory already exist.
Copy link
Collaborator

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor requests. Merge approved.

doc/changes/DM-32657.misc.rst Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/drivers.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/drivers.py Show resolved Hide resolved
python/lsst/ctrl/bps/bps_utils.py Show resolved Hide resolved
python/lsst/ctrl/bps/bps_utils.py Outdated Show resolved Hide resolved
The default error message from Python subprocess.run() when creating the
execution Butler failed was not very informative.  Customized it to
point the user to the execution Butler log file where more useful
information about the cause of the problem may be found.
@mxk62 mxk62 merged commit 21be5c5 into main Dec 6, 2021
@mxk62 mxk62 deleted the tickets/DM-32657 branch December 6, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants