Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33521: Split plugins out of ctrl_bps #1

Merged
merged 14 commits into from Apr 25, 2022
Merged

DM-33521: Split plugins out of ctrl_bps #1

merged 14 commits into from Apr 25, 2022

Conversation

mxk62
Copy link
Collaborator

@mxk62 mxk62 commented Apr 20, 2022

No description provided.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Minor comments that are the same as panda. I assume they might also be relevant for the pegasus one.

COPYRIGHT Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
examples/SConscript Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@mxk62 mxk62 force-pushed the tickets/DM-33521 branch 4 times, most recently from f504b15 to 7766b84 Compare April 22, 2022 21:12
Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a test workflow with this on the NCSA cluster and it ran successfully. Some minor questions/comments mostly about the documentation.

============

``lsst.ctrl.bps.htcondor`` is developed at https://github.com/lsst/ctrl_bps_htcondor.
You can find Jira issues for this module under the `ctrl_bps_htcondor <https://jira.lsstcorp.org/issues/?jql=project%20%3D%20DM%20AND%20component%20%3D%20ctrl_bps_htcondor>`_ component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't make components in JIRA so need to check with @timj what we're doing wrt the plugins.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make them.

doc/lsst.ctrl.bps.htcondor/userguide.rst Outdated Show resolved Hide resolved
doc/lsst.ctrl.bps.htcondor/userguide.rst Outdated Show resolved Hide resolved
doc/lsst.ctrl.bps.htcondor/userguide.rst Outdated Show resolved Hide resolved
@mxk62 mxk62 force-pushed the tickets/DM-33521 branch 2 times, most recently from dab4206 to 44568d2 Compare April 22, 2022 22:38
@mxk62 mxk62 merged commit 4644747 into main Apr 25, 2022
@mxk62 mxk62 deleted the tickets/DM-33521 branch April 25, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants