New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-33521: Split plugins out of ctrl_bps #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Minor comments that are the same as panda. I assume they might also be relevant for the pegasus one.
f504b15
to
7766b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a test workflow with this on the NCSA cluster and it ran successfully. Some minor questions/comments mostly about the documentation.
============ | ||
|
||
``lsst.ctrl.bps.htcondor`` is developed at https://github.com/lsst/ctrl_bps_htcondor. | ||
You can find Jira issues for this module under the `ctrl_bps_htcondor <https://jira.lsstcorp.org/issues/?jql=project%20%3D%20DM%20AND%20component%20%3D%20ctrl_bps_htcondor>`_ component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't make components in JIRA so need to check with @timj what we're doing wrt the plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make them.
dab4206
to
44568d2
Compare
No description provided.