Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40906: Using bps cancel raises AttributeError #24

Merged
merged 5 commits into from Sep 27, 2023
Merged

Conversation

mxk62
Copy link
Collaborator

@mxk62 mxk62 commented Sep 26, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (7931283) 15.62% compared to head (dd64beb) 15.48%.

❗ Current head dd64beb differs from pull request most recent head a21386b. Consider uploading reports for the commit a21386b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   15.62%   15.48%   -0.15%     
==========================================
  Files           4        4              
  Lines        1318     1330      +12     
  Branches      276      281       +5     
==========================================
  Hits          206      206              
- Misses       1110     1122      +12     
  Partials        2        2              
Files Coverage Δ
python/lsst/ctrl/bps/htcondor/htcondor_service.py 9.66% <0.00%> (-0.02%) ⬇️
python/lsst/ctrl/bps/htcondor/lssthtc.py 18.34% <0.00%> (-0.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1 @@
Fixed bug preventing bps cancel from working
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fixed bug preventing bps cancel from working
Fixed bug preventing ``bps cancel`` from working.

Made more clear what keys and values represent in dictionaries
returned by htc_query_histor() and htc_query_present().
Copy link

@srp3rd srp3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other comments beyond what Tim already pointed out.

@mxk62 mxk62 merged commit a0efba6 into main Sep 27, 2023
9 checks passed
@mxk62 mxk62 deleted the tickets/DM-40906 branch September 27, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants