New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-41561: Make bps restart accept various types of run IDs #25
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 15.48% 15.24% -0.25%
==========================================
Files 4 4
Lines 1330 1358 +28
Branches 281 290 +9
==========================================
+ Hits 206 207 +1
- Misses 1122 1149 +27
Partials 2 2 ☔ View full report in Codecov by Sentry. |
962df4b
to
8e2ba38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge approved. Some minor comments.
The forbidden document start "---" could be fixed by removing those initial hyphens in that file.
------- | ||
wms_dir : `str` | ||
Submit directory for the run with the given job id. If the submit | ||
directory cannot be determined, it will be set to None. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "cannot be determined" mean? Does the method guarantee that a directory exists and is readable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The submit directory can't be determined if the user provided a local job id as the run id, but there are no entries for this run in the HTCondor history file either because it rolled over or we're querying a wrong scheduler because, for example, the user ran bps restart
on sdfrome02
while the workflow was initially submitted to execution on sdfrome01
. Though I just realized that I removed the check if directory exists and is readable from the caller without putting it here. Will fix.
8e2ba38
to
1cf24df
Compare
Checklist
doc/changes